M

Inconsistent function return type hinting

  • Thread starter Thread starter mattrogowski
  • Start date Start date
M

mattrogowski

Guest

XF\Entity\UserUpgrade::setupApiResultData() has a return type of void, but XF\Mvc\Entity\Entity::setupApiResultData() doesn't and neither do seemingly most other entity classes. It means that any addons that extend XF\Entity\UserUpgrade::setupApiResultData() will break as it's arbitrarily had a return type added.

I can see that XF\Entity\UserUpgrade only had this function added in 2.3.0 Beta 4 so I presume it was an IDE autocomplete or something. It would be...

Read more

Continue reading...
 
Similar threads Most view View more
Back
Top Bottom