X

XF options do not round-trip integer/boolean values as expected

  • Thread starter Thread starter Xon
  • Start date Start date
X

Xon

Guest

PHP:
Code:
var_dump(\XF::Options()->changeLogLength);

$option = Helper::find(\XF\Entity\Option::class, 'changeLogLength');
$option->option_value = 0;
var_dump($option->option_value);

Both of these will output a string type instead of the expected int type. This matters because xf-dev:generate-options-stub CLI command gives strongly typed hints, and phpstorm (and other php code formatting tools) will suggest to unwrap any casts. Except the underlying type is stringy so...

Read more

Continue reading...
 
Back
Top Bottom