X

Webhook criteria are not easily composable

  • Thread starter Thread starter Xon
  • Start date Start date

Visitor Greeting

Welcome to NullWarehouse.com... We are currently seeking Mod's and Contributors. If you wish to apply for a Mod position then please click on Members dropdown arrow, then click on Staff App and fill it out completely and submit it. If you want to be a Contributor then start contributing and we will have our eye on you and take notice, something great could come of it.

  • We have redone the forum. If you notice any issues or errors please open a Support Ticket under the Members dropdown and let us know.
X

Xon

Guest

When implementing additional criteria, XF exposes the method XF\Webhook\Event\AbstractHandler::getCriteriaClass.

The problem is if XF doesn't implement one, it returns null. So if a 3rd party add-on implements it, it will override any other 3rd party criteria class and any future XF criteria.

IE implementing XF\Webhook\Event\PostHandler::getCriteriaClass will override any future post criteria.

I think the better solution would be for XF to implement a base criteria...

Read more

Continue reading...
 
Back
Top Bottom