We have redone the forum. If you notice any issues or errors please open a Support Ticket under the Members dropdown and let us know.

XF\Mvc\Router::prepareStringForUrl contains tiny amount of uneeded code

Thread starter Steffen
Start date Oct 24, 2024

Steffen

Guest

Oct 24, 2024

There are no double quotes left after the immediately preceeding strtr call (not completely visible in the diff below) which replaces double quotes with a space character.

Diff:

Code:

--- a/src/XF/Mvc/Router.php +++ b/src/XF/Mvc/Router.php @@ -581,7 +581,7 @@ class Router '`!"$%^&*()-+={}[]<>;:@#~,./?|' . "\r\n\t\\", ' ' . ' ' ); -       $string = strtr($string, ['"' => '', "'" => '']); +       $string = strtr($string, ["'" =>...

D	\XF\Mvc\Entity\Entity::saveIfChanged does not reset _writePending DragonByte Tech Nov 10, 2024 Xenforo RSS Feed
G	TypeError: XF\Mvc\Entity\AbstractCollection::toWebhookResults(): Argument #1 ($options) must be of type array, int given, called in /src/XF/Api/Result GameNet Nov 18, 2024 Xenforo RSS Feed
Y	public:account_preferences: [E_USER_WARNING] Accessed unknown getter on XF:UserOption[1] (src\XF\Mvc\Entity\Entity.php:22 (Add account preference) Yenxji Jan 25, 2025 Xenforo RSS Feed
M	ErrorException: [E_WARNING] Undefined array key "" src/XF/Mvc/Entity/Manager.php:584 MattW Dec 1, 2024 Xenforo RSS Feed