📢 Moderators Needed 🚀

Moderators are needed with resources to post or have access to resources to post. Submit an application to be considered.
X

RSS AbstractJob::resume() assumes getStatusMessage non-nullable return value

  • Thread starter Thread starter Xon
  • Start date Start date
X

Xon

Guest
Guest or Bot
XF2.3 added a method JobResult::newResume() which had typed arguments and the AbstractJob::resume() assumes getStatusMessage() a stringable but the getStatusMessage method was never type hinted for a return type and I've seen it return null in a few of my add-ons and a few 3rd party add-ons.

I think the best fix would be for ?? '' to be added in the resume() method and a ?string return type hint added to getStatusMessage() method.

Continue reading...
 
L
RSS  See number of likes given by a user
W
RSS  Security Error Notice
You must log in or register to reply here.
Back
Top